secondlife / secondlife/viewer
[Emoji] Display should be consistent between llDialog text and llDialog buttons
A pull request for this has already been merged.
- #1067 by @LLGuru — merged
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
Expected: The full color emoji should appear within the dialog and on the dialog buttons.
Original report
default
{
touch_start(integer total_number)
{
string on=llUnescapeURL("%e2%97%bc")+" ";
string off=llUnescapeURL("%e2%97%bb")+" ";
llDialog(llDetectedKey(0),"On = "+on+", off = "+off,[on+"on",off+"off"],-1);
}
}
The buttons show the unicode character, as before. The text is substituted with emojis which are a) confusing - the point of the text here is to reference the symbols shown on the buttons and b) incorrect in this case - a filled in white square becomes a filled in black square and a white outline box becomes a solid white square.
The llDialog text string should not go through Emoji conversion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the llDialog handling and trace how emoji conversion is applied to dialog text and buttons. Compare the two rendering paths against the reported example; done means the dialog text preserves the referenced Unicode symbols while the buttons continue displaying them consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100