Avoid reading the same XML file multiple times

Environment

Any version of SecondLife viewer

Description

Some XML files are being read very often, multiple times per session

For chat messages:

indra\newview\skins\default\xui\en\panel_chat_header.xml
indra\newview\skins\default\xui\en\inspector_info_ctrl.xml
indra\newview\skins\default\xui\en\panel_chat_separator.xml

For notifications:

indra\newview\skins\default\xui\en\favorites_bar_button.xml
indra\newview\skins\default\xui\en\panel_notification.xml
indra\newview\skins\default\xui\en\panel_toast.xml

And maybe some other files, needs investigate

Reproduction steps

1. Create file logcontrol-dev.xml in the folder C:\Users\user\AppData\Roaming\SecondLife\user_settings
   with the following contents:

<llsd>
 <map>
  <key>default-level</key>
  <string>ERROR</string>
  <key>print-location</key>
  <boolean>false</boolean>
  <key>settings</key>
  <array>
   <map>
    <key>level</key>
    <string>DEBUG</string>
    <key>functions</key>
    <array>
     <string>parseFile</string>
    </array>
   </map>
  </array>
 </map>
</llsd>

2. Start SL viewer, open chat floater, view notifications and so on

3. Close viewer

4. Read the file C:\Users\user\AppData\Roaming\SecondLife\logs\SecondLife.log

5. Verify repeated readings of the same XML files

Links

Is integrated into

• https://github.com/secondlife/viewer/tree/DRTVWR-600-maint-A

Start by reproducing the report with logcontrol-dev.xml and inspect SecondLife.log for repeated parseFile entries. Trace the listed chat and notification XML files under indra/newview/skins/default/xui/en, then determine the relevant loading paths. Done means the same XML resources are no longer read repeatedly during a viewer session and the behavior is verified in the log.