secondlife / secondlife/viewer

libpng-1.6.38-ca06e99-windows64-ca06e99.tar.zst compiled with /GL and causing linker warning in VS2022

Open
#695 1 comment 0 reactions 1 assignee View on GitHub

@brad-linden is already working on this.

Since Feb 13, 2024.

bug stale
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

Environment

Seen by using LL's https://github.com/secondlife/3p-libpng/releases/download/v1.6.38-ca06e99/libpng-1.6.38-ca06e99-windows64-ca06e99.tar.zst pre-built library to replace https://automated-builds-secondlife-com.s3.amazonaws.com/ct2/87780/805832/libpng-1.6.8.563850-windows64-563850.tar.bz2 for TPV Windows builds.

Description

I am in the process to migrate to LL's github libraries builds for the Windows64 builds of the Cool VL Viewer, and when doing so I get, at link time:
"libpng16.lib(png.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance"
I do not encounter this problem if I revert libpng to the old bitbucket built package.
As I understand it, this would be due to a wrong /GL option given when compiling libpng for Windows...

Reproduction steps

Build the viewer under VS2022 using https://github.com/secondlife/3p-libpng/releases/download/v1.6.38-ca06e99/libpng-1.6.38-ca06e99-windows64-ca06e99.tar.zst for libpng, and observe the warning at link time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.