secondlife / secondlife/viewer

Duplicate `name` attributes on sibling nodes with the same tag name in XML files within `xui\en`

Open
#6,316 1 comment 0 reactions 1 assignee View on GitHub

@maxim-productengine is already working on this.

Since Sep 15, 2026.

  • #6323 by @maxim-productengine — merged
bug
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

In the XML files located in the /indra/newview/skins/default/xui/en folder on the 2026-09-13 develop branch, there are four instances where sibling nodes with the same tag name have the same name attribute value. Since this hinders localization, please change them to appropriate names.

floater_model_preview.xml

983: There are two elements inside

1013: <text name="quality_label">Resolution:</text>

2022: <text name="quality_label">Hulls per Mesh:</text>

This node is not currently used on Windows, so it could not be tested

menu_viewer.xml

2143: There are two <menu_item_check name="Rendering Type Glow"> elements inside

2189: <menu_item_check label="Glow" name="Rendering Type Glow">

2199: <menu_item_check label="Fullbright" name="Rendering Type Glow">

2841: There are two <menu_item_call name="Force LLError And Crash"> elements inside

2853: <menu_item_call label="Force LLError And Crash" name="Force LLError And Crash">

2859: <menu_item_call label="Force LLError, Message And Crash" name="Force LLError And Crash">

mime_types.xml

2: There are two elements inside .

312: <mimetype name="application/octet-stream">

       <label name="application/octet-stream_label">Stream</label>

       <widgettype>movie</widgettype>

       <impl>media_plugin_libvlc</impl>

     </mimetype>

499: <mimetype name="application/octet-stream">

       <label name="video/octet-stream">Movie</label>

       <widgettype>movie</widgettype>

       <impl>media_plugin_libvlc</impl>

     </mimetype>

Each child has a `label` element, but the `name` attribute is set to `application/octet-stream_label` or `video/octet-stream`, and the text nodes within them contain strings that should be translated.

https://secondlife.canny.io/admin/feedback/bug-reports/p/duplicate-name-attributes-on-sibling-nodes-with-the-same-tag-name-in-xml-files-w

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.