secondlife / secondlife/viewer
Inworld Notices randomly removed
A pull request for this has already been merged.
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
Description
Persisted notifications are trimmed wrongly, which causes the latest notifications to be dropped on relog instead of trimming starting from the oldest notifications.
Before logging out (4 notifs): https://gyazo.com/60b8ab529e447f7ba32623cc6372116a
After logging back in (2, the older ones): https://gyazo.com/44084cf468f849abd08059d2f95fbe47
For an easy test, change MaxPersistentNotifications to 2.
Note that texture picker does not permit minimization and simply hides.
Same ticket on firestorm: https://jira.firestormviewer.org/browse/FIRE-36502
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating MaxPersistentNotifications and the persisted-notification trimming path used during logout and relogin. Reproduce the issue with the value set to 2, then verify that the oldest notifications are removed while the latest ones remain after relogin.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100