secondlife / secondlife/viewer
Optimize viewer cleanup
A pull request for this has already been merged.
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
Description
Task
Cleanup can take multiple seconds on a powerfull PC, try to make it at least twice faster.
On the screen is cleanup from the time the button was clicked till termination. Not sure why it's so messed up, but it shows at least some problematic places and that cleanup took almost 3 seconds.
Notes
Viewer's cleanup is incredibly 'flat'. Alsmost everything happens in a single pass in a single thread. Potenatially some things can be threaded, like caching. Texure thread needs to be spread over instead of waiting at the end. Media cleanup needs to be looked over.
Test plan
Confirm settings, inventory, chat cache persist across logins.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, entry point, or automated test is named. Start by reproducing the viewer cleanup timing and examining the attached profile, then trace the cleanup work described in the notes; done means cleanup is at least twice as fast while settings, inventory, and chat cache persist across logins.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100