secondlife / secondlife/viewer

[Mac] Saving snapshot to disk disabled until relog if file picker aborted

Open
#5,504 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug stale team:viewer
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

Might just be on Mac.

Steps to repro :

  1. Pull up snapshot window

  2. Click save to disk to bring up file/folder/finder window

  3. DO NOT COMPLETE save - leave the file picker window open (dont click save or cancel) but then move focus to somewhere else e.g. click on group messages

  4. As soon as you do this the file picker window disappears and the snapshot panel is left hanging on "saving to computer"

  5. You can close the snapshot window but if you then open it again e.g. to save a new snapshot it remains per 4. hanging until you relog

This sort of thing was also happening on the build/upload panel (e.g. upload model) previously but seems to have been fixed. i.e when going through this process, the file picker panel comes up but the rest of SLV is disabled until you complete or cancel. So i think that approach just needs to be adopted for saving snapshots too..?

https://secondlife.canny.io/admin/feedback/bug-reports/p/saving-snapshot-to-disk-disabled-until-relog-if-file-picker-aborted


This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #5504 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @canny[bot] (replace 20 with the amount, and @canny[bot] with the user to tip).

📖 If you want to learn more, check out our documentation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the snapshot window's save-to-disk flow and reproduce the file-picker focus change on macOS. Compare it with the build/upload panel behavior described in the report. Done means abandoning or moving focus from the picker does not leave the snapshot panel stuck, and a later snapshot can be saved without relogging.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.