secondlife / secondlife/viewer
Cleanup fake bool usage where they are unnecessary or incorrect
A pull request for this has already been merged.
- #5156 by @Hecklezz — merged
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
PR: https://github.com/secondlife/viewer/pull/5156
There is a few places remaining in the viewer where fake bools (BOOL/FALSE/TRUE) are used where they aren't necessary and/or the signature of the function they are used in expects a regular bool.
There are uses of fake bools for pre-existing APIs such as WinAPI or gtk, which should be left untouched and not refactored to follow standards.
The fake bool used in the LL Havok lib- LLPathingLib::createPhysicsCapsuleRep should ideally be updated too, so then the fake bool usage of that function can be removed from the viewer side as well.
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting
/reward 100 (replace 100 with the amount).🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment
/try to let everyone know!🙌 And when they open the PR, they can comment
/claim #5155 either in the PR description or in a PR's comment.🪙 Also, everyone can tip any user commenting
/tip 20 @Hecklezz (replace 20 with the amount, and @Hecklezz with the user to tip).📖 If you want to learn more, check out our documentation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review merged PR #5156 to see which viewer locations were changed and whether the remaining fake BOOL/FALSE/TRUE uses are covered. Pay particular attention to LLPathingLib::createPhysicsCapsuleRep and its LL Havok implementation; done means unnecessary uses are cleaned up while pre-existing WinAPI and GTK APIs remain untouched.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 15/100