secondlife / secondlife/viewer
develop-linux branch, glb, gltf missing from file picker, only *.dae selectable.
A pull request for this has already been merged.
- #4954 by @RyeMutt — merged
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
Problem
The SDL/Linux file picker only showed Collada/DAE files in the mesh import dialog, despite the model loader already
supporting GLB/GLTF formats.
Solution
Updated FFLOAD_MODEL filter in llfilepicker.cpp (line 213) to include all supported formats: dae, gltf, glb
File: indra/newview/llfilepicker.cpp:213
Changed:
filter_vec.push_back({ "Model files (*.dae)", "dae" });
To:
(Canny is screwing this line up, it should have astericks.type)
filter_vec.push_back({ "Model files (*.dae, *.gltf, *.glb)", "dae;gltf;glb" });
This aligns the Linux implementation with Windows (line 62) and the model loader's actual capabilities
(llmodelpreview.cpp:795-837).
Test plan
- test plan needed.
- Does this need to be tested on a specific flavor of Linux? Is Ubuntu / gnome ideal?
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting
/reward 100 (replace 100 with the amount).🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment
/try to let everyone know!🙌 And when they open the PR, they can comment
/claim #4958 either in the PR description or in a PR's comment.🪙 Also, everyone can tip any user commenting
/tip 20 @canny[bot] (replace 20 with the amount, and @canny[bot] with the user to tip).📖 If you want to learn more, check out our documentation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in indra/newview/llfilepicker.cpp at the FFLOAD_MODEL filter around line 213, then compare the Windows filter at line 62 and supported formats in llmodelpreview.cpp:795-837. Verify that the Linux file picker lists and accepts DAE, GLTF, and GLB files, and define a Linux test plan covering the model import dialog; no specific test file is named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100