secondlife / secondlife/viewer
When login fails due to large inventory, explain that instead of blaiming server
A pull request for this has already been merged.
- #4738 by @akleshchev — merged
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
Viewer should recognizing that inventory takes too long to create and is the cause for a login failure. Log such a case and warn user apropriately instead of blaming connection to server.
Potentially detect when inventory takes dangerously long, LL_WARN that and notify user.
Test Plan
Set LoginSRVTimeout very low with large inventory, when viewer fails to login, message should be more informative about the reason.
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting
/reward 100 (replace 100 with the amount).🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment
/try to let everyone know!🙌 And when they open the PR, they can comment
/claim #4737 either in the PR description or in a PR's comment.🪙 Also, everyone can tip any user commenting
/tip 20 @akleshchev (replace 20 with the amount, and @akleshchev with the user to tip).📖 If you want to learn more, check out our documentation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the viewer's login failure handling around LoginSRVTimeout and the large-inventory creation path. Reproduce the case with a very low LoginSRVTimeout and a large inventory; done means the viewer logs the inventory-delay cause and presents a more informative warning instead of blaming the server connection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- authentication, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100