secondlife / secondlife/viewer
Enforce Reflection probe restrictions on attachments
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
As per https://wiki.secondlife.com/wiki/PBR_Materials#Unsupported_use-cases reflection probes are not supposed to work as attachments or on physics objects.
Wear a reflection probe. This intentionally does not work.
Except, it does work - you just have to make the probe be a linked part, rather than a root object.
This should be fixed so it doesn't become a feature due to people exploiting it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the linked PBR Materials unsupported-use-cases description as the behavior reference, then trace reflection-probe handling for attachments, linked parts, and physics objects in the viewer. Done means reflection probes are rejected consistently in those cases, including when the probe is a linked part.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100