secondlife / secondlife/viewer

Water displaying incorrectly since 7.1.12 with certain environment settings

Open
#4,096 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug stale team:viewer triage
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

Environment

Second Life Release 7.1.13.14343205944 (64bit)

Rest of environment- Release Notes

CPU: Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (3600 MHz)
Memory: 16302 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.5854)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce RTX 2080/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.6636
OpenGL Version: 4.6.0 NVIDIA 566.36

Window size: 1634x928
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 256m
Bandwidth: 3000kbit/s
LOD factor: 1.5
Render quality: 4
Texture memory: 8192MB
Disk cache: Max size 1638.4 MB (12.8% used)

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.24.2 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version:

May 17 2025 02:30:10

Description

Since changes made in 7.1.12 (7.1.11 and before doesn't exhibit these issues), certain water environments are rendering incorrectly depending on the setting chosen for the water environment. Also depends on the angle you view them at, some of them if you look at them from a top-down angle, they appear correct.

Here is a screenshot of it rendering incorrectly-

Not working screenshot

Image

Here is a screenshot of it rendering correctly on a 7.1.11 build-

Working screenshot

Image

The location used for testing- http://maps.secondlife.com/secondlife/Shoreline/27/83/20

List of non-working/changed water environments based on the provided location-
Some of these look correct if you look from a top-down angle instead of straight on at a normal view angle

  • Shared Environment (would be dependent on the region settings, but at the location solid dark blue)
  • Lassies Clearwater (Solid dark blue)
  • Nacon's Capiliry OCE (Solid light blue)
  • Nacon's Frozen water (Solid blue, with only some ice effects, but not ice everywhere like in 7.1.11)
  • Nacon's Pixel Water (Solid aqua)
  • Nacon's Pixel Water 2 (Pixel effect really exaggerated)
  • Nacon's Retro-wave water (Retro-wave effect really exaggerated)
  • Nacon's Retro-wave water 2 (Retro-wave effect really exaggerated)
  • [TOR] Coral Reef (Sky blue, looks correct from top-down)
  • [TOR] Fantastuck (Blue and reflective)
  • [TOR] Freak-A-dermia (Light blue, looks correct from top-down)
  • [TOR] Glaznost (Solid grey)
  • [TOR] Grantamount (Light blue, looks correct from top-down)
  • [TOR] Hpmod (Solid grey)
  • [TOR] Placida Brite (Solid grey)
  • [TOR] Raw sewage (Solid dark brown)
  • [TOR] Showing age (Solid dark grey-blue)
  • [TOR] Whickedly (Solid grey)

Possibly many more are "incorrect" but they are close enough to what they should be that it isn't easy to tell without closely looking.

If a lot more screenshots are required to show the drastic change in rendering, I can take the time to try and make as many comparison screenshots as I can.

Reproduction steps
  1. Visit http://maps.secondlife.com/secondlife/Shoreline/27/83/20
  2. Use shared environment for water, or any of the other ones with issues listed above
  3. Observe the water is just a void of solid dark blue, instead of correctly looking like water waves, or any of the incorrect colours/effects if not using the shared environment.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at Shoreline/27/83/20 using the listed water environments, comparing viewer 7.1.13 with a 7.1.11 build and varying the viewing angle. Investigate the water-rendering behavior associated with the 7.1.12 changes. Done means the affected environments display their expected waves, colors, reflections, and effects at normal viewing angles.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.