secondlife / secondlife/viewer

Legacy bump breaking change under PBR/ForeverFPS

Open
#3,755 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug team:viewer
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

Location to reproduce:

http://maps.secondlife.com/secondlife/Han%20Loso/72/190/59

Steps to reproduce:

  1. Touch 3-4 perimeter buttons on the circular dialing control in front of the gate.

  2. Observe the illuminated chevrons on the gate ring itself

This bug seems to present on fullbright surfaces using the legacy bumpiness options.

I've isolated the component of the object that demonstrates this bug and attempted setting it to bumpiness:none and back to bumpiness:bark as it should have, and it looks much better. Changing my selection away from the item however makes it revert to the broken state.

Items should not change how they look based on if they are selected or not, and legacy content should not look this different, the right example in my isolated example screenshot is completely acceptable if it can be achieved without it resetting on de-selection.

Additional wacky aspect of this comes in when scaling the item: https://youtu.be/qB7tVtKFMOQ

This scaling issue does not at-all repro on FS 6.x

https://secondlife.canny.io/admin/board/bug-reports/p/legacy-bump-breaking-change-under-pbr-foreverfps

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at the Han Loso location by touching several perimeter buttons and checking the gate's illuminated chevrons. Compare the selected and deselected states, including scaling behavior, with Firestorm 6.x as described. Done means legacy bumpiness surfaces keep the same acceptable appearance after deselection and scaling.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.