secondlife / secondlife/viewer

Edited Legacy EEP settings applied on pre-ExtraFPS viewers can appear dark

Open
#3,531 0 comments 0 reactions 1 assignee View on GitHub

@Geenz is already working on this.

Since Feb 14, 2025.

bug stale team:viewer
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

Environment

ForeverFPS Beta: 7.1.12.13206144235
Possibly any viewer with https://github.com/secondlife/viewer/issues/3169

Description

If Reflection Probe Ambiance is untouched on legacy EEP settings and applied to a region sky while using a pre-ExtraFPS viewer (or FS 7.1.11 for instance), users on more recent viewers will see the scene to be completely dark.
These more recent viewers are automatically adjusting the reflection probe ambiance of a legacy sky to 0. Whereas the pre-ExtraFPS viewers do not.

Image

Note that if the Reflection Probe Ambiance is changed, this issue does not reproduce.
Legacy skies are showing the Reflection Probe Ambiance as 0.01 but readjusting back to 0.01 shows a completely different lit scene.

Reproduction steps

User A on FS 7.1.11 (or SL DeltaFPS)
User B on ExtraFPS or ForeverFPS (or FS Beta 7.1.12)

  1. User A: Grab the legacy sky, Whirly Gloomy Day, from the Library and set HDR Scale to 0. The sky appears as so:

Image

  1. User A: Save the EEP setting and send it to User B
  2. User B: Open the sky setting. It appears as the following:

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.