secondlife / secondlife/viewer

Chat icon in Conversations window flashes for every message in separated chat window

Open
#3,336 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug team:viewer
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

When I have a chat in a separated window, the original icon in the Conversations window will flash for every message no matter if it's read or unread.

To reproduce:

  1. Have an active chat going (for example by IMing somebody)

  2. Open the Conversations window

  3. Click the "Move this conversation to a separate window" button

  4. Tab into the text input field of the new chat window

  5. Receive an IM. Since this conversation is your active window, you've read this message.

  6. You will see that the original icon in the Conversation window flashes even though.

Also, when you receive an IM while the separated window is currently not your active window, tabbing back into it will not remove the flashing of the original icon in the Conversations list.

My specific use case is the "Nearby chat" icon. I have the Nearby Chat in a separated window since it had been like that in the old days and I'm used to it. The constantly flashing "Nearby chat" icon in the conversations list drives me crazy. I wish there was no icon at all. Maybe you could remove every icon that belongs to a separated window if this feature request ever gets implemented https://feedback.secondlife.com/feature-requests/p/show-im-status-icons

https://secondlife.canny.io/admin/board/bug-reports/p/chat-icon-in-conversations-window-flashes-for-every-message-in-separated-chat-wi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the separated conversation window behavior described in the issue, focusing on the Conversations window icon and the active or inactive separated chat. Trace the UI code handling message notifications and focus changes. Done means messages read in the separated window no longer make its original Conversations icon flash, and returning focus clears any applicable flashing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.