secondlife / secondlife/viewer
BugSplat Crash: SecondLifeViewer!LLInlineViewSegment::clone(3884)
A pull request for this has already been merged.
- #3195 by @akleshchev — merged
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Description
BugSplat Key Crash 96513
Some Customer Responses:
ASSERT (NOT SUPPORTED) - mailto:Mnikolenko ProductEngine
ASSERT (NOT SUPPORTED) - mailto:Rider Linden
ASSERT (NOT SUPPORTED) - mailto:Mercury Linden
ASSERT (NOT SUPPORTED) - mailto:Garry Linden
ASSERT (NOT SUPPORTED) - mailto:Dan Linden
Sample Version:
7.1.12.11492153866
Sample Callstack:
| SecondLifeViewer!LLInlineViewSegment::clone | C:/a/viewer/viewer/indra/llui/lltextbase.cpp(3884) |
| SecondLifeViewer!LLTextBase::insertSegment | C:/a/viewer/viewer/indra/llui/lltextbase.cpp(1075) |
| SecondLifeViewer!LLTextBase::insertStringNoUndo | C:/a/viewer/viewer/indra/llui/lltextbase.cpp(906) |
| SecondLifeViewer!LLChatHistory::appendMessage | C:/a/viewer/viewer/indra/newview/llchathistory.cpp(1592) |
| SecondLifeViewer!LLFloaterIMSessionTab::appendMessage | C:/a/viewer/viewer/indra/newview/llfloaterimsessiontab.cpp(679) |
| SecondLifeViewer!LLFloaterIMNearbyChat::addMessage | C:/a/viewer/viewer/indra/newview/llfloaterimnearbychat.cpp(644) |
| SecondLifeViewer!LLNotificationsUI::LLFloaterIMNearbyChatHandler::processChat | C:/a/viewer/viewer/indra/newview/llfloaterimnearbychathandler.cpp(555) |
| SecondLifeViewer!LLVoiceWebRTCConnection::OnDataReceivedImpl | C:/a/viewer/viewer/indra/newview/llvoicewebrtc.cpp(3077) |
| SecondLifeViewer!std::_Func_class::operator() | C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.41.34120/include/functional(920) |
| SecondLifeViewer!LL::WorkQueueBase::callWork | C:/a/viewer/viewer/indra/llcommon/workqueue.cpp(113) |
| SecondLifeViewer!LL::WorkQueueBase::runUntil | C:/a/viewer/viewer/indra/llcommon/workqueue.cpp(85) |
| SecondLifeViewer!LL::WorkQueueBase::runFor<__int64,std::ratio<1,1000000000> > | C:/a/viewer/viewer/indra/llcommon/workqueue.h(180) |
| SecondLifeViewer!LLAppViewer::idle | C:/a/viewer/viewer/indra/newview/llappviewer.cpp(4765) |
| SecondLifeViewer!LLAppViewer::doFrame | C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1599) |
| SecondLifeViewer!LLAppViewer::frame | C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1424) |
| SecondLifeViewer!wWinMain | C:/a/viewer/viewer/indra/newview/llappviewerwin32.cpp(492) |
| SecondLifeViewer!invoke_main | D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(118) |
| SecondLifeViewer!__scrt_common_main_seh | D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(288) |
| kernel32!BaseThreadInitThunk | |
| ntdll!RtlUserThreadStart |
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with indra/llui/lltextbase.cpp around LLInlineViewSegment::clone and LLTextBase::insertSegment, then trace the chat path through indra/newview/llchathistory.cpp and llfloaterimsessiontab.cpp. Use the provided call stack and merged pull request #3195 to determine the resolved behavior; done means the reported crash is addressed and the relevant chat insertion path no longer reproduces it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100