secondlife / secondlife/viewer

Show 'Members not loaded' in 'Assigned members' when list isn't loaded yet

Open
#2,965 4 comments 0 reactions 1 assignee View on GitHub

@akleshchev is already working on this.

Since Nov 5, 2024.

  • #5692 by @akleshchev — merged
enhancement triage
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

Feature

Populate 'assigned members' list with a 'members not loaded' string when members aren't loaded instead of showing an empty list.
Might also add 'Loading...' if request for members was made. String might benefit from some sort of highlight be that color or style, but plain string should be enough.

Reason

It's confusing to see an empty 'assigned members' list, showing a basic 'not loaded' string should promt user to check member list instead of thinking that something broke.

Image

Test plan (?)
  • Clear the cache
  • Log in
  • Open a group info floater
  • Select Roles & Members section.
  • The Roles tab should have focus by default.
  • Select a Role that has some users in it.
  • Verify the Assigned Members section says "Members List not Loaded"
  • Click the Members tab. This loads the members.
  • Click the Role tab.
  • Select a Role that has some users in it, again.
  • Verify the Assigned Members section now shows the actual member names.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.