secondlife / secondlife/viewer

Avoid light source dots in reflections

Open
#2,956 3 comments 0 reactions 1 assignee View on GitHub

@Geenz is already working on this.

Since Jan 7, 2025.

bug team:viewer
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

PBR Reflective surfaces with metallic=1, roughness=0 and alpha=0.5 that receive image from a reflection probe should not show any light source dots no matter if they are point lights or projectors, there is no need for reflection probes to include these dots on their scan of the scene around, this spoils the illusion of glass reflections, as shown in picture.

https://secondlife.canny.io/admin/board/bug-reports/p/avoid-light-source-dots-in-reflections

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.