secondlife / secondlife/viewer

(PBR) Moon clips with skydome

Open
#1,445 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug knownissue team:viewer
Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Description

The moon texture clips with skydome geometry, regardless of what the sky detail is set to in graphics preferences. If the sun is given the same texture, it does not clip.

Steps to reproduce:

  1. Inventory->new settings->new sky. Edit the new sky.

1b) optional: set cloud density and coverage to maximum to see it easier, but it is noticeable as long as there are any clouds at all.

  1. Move the sun and moon to the same azimuth and nearby elevations, I used 270 azimuth and 33 elevation for testing. The effect is worse at higher elevations.

  2. Set the sun and moon to the same texture, for instance "moon" from the library.

  3. Set sun scale to 10, moon scale to minimum. Move the camera around while viewing the sun; it does not flicker.

  4. Set the moon scale to 10, sun scale to minimum, do the above; the moon flickers and clips against the skydome geometry. Changing the sky detail level in preferences changes the granularity of the flicker, but doesn't avoid it.

In the attached screenshot, top is the sun, bottom is the moon, moon has been set to 0 brightness. Elevations 45 and 30 respectively.

https://secondlife.canny.io/admin/board/bug-reports/p/pbr-moon-clips-with-skydome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by creating a new sky, aligning the sun and moon, and assigning both the same texture as described. Compare the sun and moon while moving the camera, then verify that the moon no longer flickers or clips against the skydome across sky detail settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.