IPOptions_Timestamp does not support multiple IP Address and Timestamp fields
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 12.6k
- Forks
- 2.2k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 56
Description
Brief description
When the IPv4 Timestamp option is added to an IP packet, "the originating host must compose this option with a large enough timestamp data area to hold all the timestamp information expected." This involves multiple timestamp fields (and IP addresses fields, based on flag) initialized to 0 / 0.0.0.0.
Currently, scapy supports only one timestamp field within IPOptions_Timestamp(), which means the target host is unable to add any timestamp to the packet, and will reply with an IP Option Timestamp having the overflow flag set to 1.
Scapy version
2.5.0
Python version
3.9.2
Operating system
Linux 5.15.0-118
Additional environment information
No response
How to reproduce
No specific steps. Refer to issue description
Actual result
No response
Expected result
No response
Related resources
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the IPOptions_Timestamp() implementation and any related packet-option tests. Check how timestamp and address fields are represented and initialized, then verify that the option can hold multiple fields for the relevant flags without setting overflow; add or update coverage for this behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100