Duplicated skinny protocol
Open
Nobody has claimed this yet.
cleanup
- Dominant language
- Python
- Stars
- 12.6k
- Forks
- 2.2k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 56
Description
Just noticed we have the skinny protocol twice, since https://github.com/secdev/scapy/commit/b1da6edc6deffbee52eaa8dcf3b8270f27a34860 where phil 'added' skinny:
We should eventually work towards merging the two.. idk?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the duplicated protocol implementations in scapy/contrib/skinny.py and scapy/layers/skinny.py, starting from the linked commit b1da6ed. Identify how the two definitions differ and determine the intended merged location and scope. Done means the Skinny protocol is represented once without losing existing functionality.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100