seas-computing / seas-computing/mark-one
Address DOM element prop warning
Open
Nobody has claimed this yet.
Frontend
refactor
Technical Debt
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Description
Are are getting these warnings in the console on our apps that use components with the following properties:
- isSticky
- isStriped
- isScrollable
- verticalAlignment
These warnings are:
Warning: React does not recognize the isXxxx prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase isxxxx instead. If you accidentally passed it from a parent component, remove it from the DOM element.
and
styled-components: it looks like an unknown prop "________" is being sent through to the DOM, which will likely trigger a React console error. If you would like automatic filtering of unknown props, you can opt-into that behavior via <StyleSheetManager shouldForwardProp={...}> (connect an API like @emotion/is-prop-valid) or consider using transient props ($ prefix for automatic filtering.)
We should refactor the components that make use of these props to address these issues.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the components that use isSticky, isStriped, isScrollable, and verticalAlignment, then reproduce the reported React and styled-components warnings in an application using them. The work is done when those props no longer produce unknown-prop console warnings while the components retain their intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100