seas-computing / seas-computing/mark-one
Fix FlexWrapper Component
Open
bug
Frontend
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Description
Our current implementation for the FlexWrapper component needs to be fixed. We've set it up now as (condensed):
const StyledFlexWrapper = styled.div`
...
`
const FlexWrapper = () => (
<StyledFlexWrapper>
{children}
</StyledFlexWrapper>
)
So the rules we're trying to add only get applied to the FlexWrapper itself, which is a kind of transient component that doesn't actually get rendered; instead we just get the underlying StyledFlexWrapper styles without any of these changes.
We should modify this component to just directly export the styled.div instead of adding the additional transient component.
Additional Information
We should make sure to update our mark-one package in makerspace after making this fix.
Previously discussed here
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.