seanmonstar / seanmonstar/httparse
Benchmark is not an apples to apples comparison (sse4.2)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 713
- Forks
- 135
- PR merge metrics
- No merged PRs in 30d
Description
Hello, first, thanks for making this tool.
I wanted to point out your benchmark is a bit unfair as you compare httparse sse4 against picohttpparser without sse4. The reason picohttpparser doesn't have sse4 is because your dependency 'pico-sys' does not compile picohttpparser with sse4 enabled.
Your benchmark showed a ~60% improvement in performance for 'bench_pico' once sse4 was enabled in the underlying crate.
I forked the underlying crate 'pico-sys' and made a few modifications if you want to verify my results:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the benchmark entry point for bench_pico and the pico-sys dependency configuration. Verify how httparse and picohttpparser are built, then compare both with SSE4 enabled; done means the benchmark uses equivalent SIMD settings and reports a fair comparison.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100