Prevent target_id to be matched with multiple catalogids
Open
@albireox is already working on this.
Since May 28, 2020.
- Dominant language
- Python
- Stars
- 6
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Currently, in phase 2, there is nothing preventing a target to be matched with multiple catalogids as long as they are all within valid distance in the radial query.
To prevent this we could add an initial window function to the cross-match query, partitioning by target_id and selecting only first_value with the closest distance to catalogid. That query would be treated as a subquery to which we then apply the usual partition to define best.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.