sdss / sdss/sdssdb

Should we integrate SQLModel into the package?

Open
#269 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Python
Stars
8
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Should we integrate SQLModel into sdssdb for the SQLAlchemy models? I don't think this is strictly necessary for 1.0, but maybe this is something to consider for later. If we don't want a complete integration here, perhaps a smaller wrapper library could be considered.

Pros
  • Automatically creates pydantic models for validation / serialization for all our ORMs.
  • No need to duplicate code in downstream packages
  • Makes it easier to drop into future python API services / frameworks
Cons
  • Increases the dependency stack
  • No integration with peewee models

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the package's existing SQLAlchemy models and the mentioned peewee models; the issue names no files, tests, or entry point. Determine whether full SQLModel integration or a smaller wrapper is wanted, with a clear decision on scope and trade-offs as the definition of done.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlalchemy
Domain
backend, database
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.