sdss / sdss/sdssdb

Support drivers other than PostgreSQL

Open
#19 0 comments 0 reactions 1 assignee View on GitHub

@albireox is already working on this.

Since Sep 22, 2019.

enhancement
Dominant language
Python
Stars
8
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Right now it's hardcoded in sdssdb that all the databases are PostgreSQL. In principle we may need to support other databases (e.g. SQLite or SQL Server) and should be able to use all the current framework. Both Peewee and SQLA support multiple drivers.

On the SQLA side this seems relatively simple, since the driver is specified as a string. For Peewee is a bit more complicated; we'd need to create a PeeweeBaseDatabaseConnection and then subclass from the appropriate Peewee connection class and make sure the __init__ is run correctly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.