sdss / sdss/explorer

feat: advanced expressions

Open
#41 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature quality of life
Dominant language
Python
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

advanced filtering:

  • e_teff^2 < abs(e_fe_h)
  • e_teff^2 + e_logg^2 < 0

the reason this would be implemented is that we don't want to force a user to make a virtual column, and then enter this virtual column as an expression.

would require a refactor of expressions once again, and maybe forcing a stricter AST check as opposed to string REGEX, but this likely will sacrifice speed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reviewing the existing expression handling and its current string-regex validation, then determine how the example comparisons and arithmetic should be represented and checked in a stricter AST-based design. Done means users can enter these advanced expressions without creating a virtual column, with the supported syntax and validation behavior covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.