scylladb / scylladb/cpp-rs-driver

Fix `MonotonicTimestampGenerator` test and remove `src/timestamp_generator.[cpp/hpp]`

Open
#296 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/testing P4
Dominant language
C++
Stars
26
Forks
19
Avg merge
1d 21h
Merged PRs (30d)
7

Description

This test implements its custom wrapper over MonotonicTimestampGenerator (defined in src/timestamp_generator.cpp). The wrapper's next() implementation simply appends generated timestamp to vector. This vector is then inspected during the test.

To remove the files mentioned in PR title, we firstly need to implement some testing utility API on rust side which would allow to collect the generated timestamps and inspect them. The test needs to be rewritten using this API.

All this should be done once https://github.com/scylladb/cpp-rust-driver/pull/295 is merged.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking whether PR #295 is merged, then inspect the test's custom wrapper and src/timestamp_generator.cpp plus src/timestamp_generator.hpp. Implement or use the Rust-side testing utility needed to collect and inspect generated timestamps, rewrite the test around it, and remove the two C++ timestamp generator files once the test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.