scverse / scverse/squidpy

Documentation of spatial_scatter

Open
#844 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

doc maint :building_construction:
Dominant language
Python
Stars
598
Forks
121
Avg merge
3d 11h
Merged PRs (30d)
3

Description

https://github.com/scverse/squidpy/blob/16a9885976e24778664c81c05a9b592b2bd4a237/src/squidpy/_docs.py#L222-L223

The documentation for legend_loc in spatial_scatter refers to matplotlib.legend.Legend which is wrong I think. The legend_loc variable is passed to the scanpy function _add_categorical_legend (code), so it seems like the only valid options for legend_loc are ["right margin", "on data"] which should be specified in the documentation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/squidpy/_docs.py lines 222-223 and compare the legend_loc description with Scanpy's _add_categorical_legend implementation in scanplots.py. Update the parameter documentation to describe the supported values, then run the relevant documentation or test checks to confirm the rendered API reference is correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.