scverse / scverse/squidpy

spatial_neighbors unintended in-place change

Open
#1,154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
598
Forks
121
Avg merge
3d 11h
Merged PRs (30d)
3

Description

Does this mutate in-place?

Originally posted by @timtreis in https://github.com/scverse/squidpy/pull/1134#discussion_r3045306190

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the spatial_neighbors implementation and inspect how its inputs are handled during the operation. Reproduce the reported case to determine whether an input is mutated in place; done should include a confirmed behavior and a regression test or clarification of the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.