scverse / scverse/spatialdata

Check what is passed to **kwargs in the parsers to avoid silent bugs

Open
#85 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement ✨
Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

Typos can lead to parameters being not specified inside parsers and their default value (None) can lead to nasty bugs. I would add checks that the argument passed to kwargs are actually the expected (like customization for spatial-image)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the parser implementations and the spatial-image customization referenced in the issue. Compare the arguments passed through kwargs with each parser's expected parameters, then verify that unexpected names are reported instead of silently using None; the issue does not name specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.