Cases uncaught from validation for raster data
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 394
- Forks
- 95
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 7
Description
The xarray.DataArray constructed here https://github.com/single-cell-data/TileDB-SOMA/blob/fe8e64d88173b0d79d93893a778eb481a75ff2c5/apis/python/src/tiledbsoma/io/spatial/outgest.py#L309 creates a object that passes our validation but that differs from the same object after a call of the parser in the .indices and .coords.
We should ensure that the validation is not passed when those variables are not set. I suspect the problem appears also for multiscale images.
- test for mutliscale images as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at apis/python/src/tiledbsoma/io/spatial/outgest.py around line 309, where the xarray.DataArray is constructed. Compare validation before and after the parser, focusing on .indices and .coords when those variables are unset. Add coverage for raster data and verify the unchecked multiscale-image case is covered as well.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100