Extent calculation doesn't account for radius of Points
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 394
- Forks
- 95
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 7
Description
Just fixed https://github.com/scverse/spatialdata-plot/pull/334 and noticed that the extent calculation does not account for the radius of points. In the first version of this picture we calculated this within spatialdata-plot but that has since moved upstream. It's realistically not super noticeable if these are small, but f.e. in our test case it stands out:
Can be mitigated through the pad_extent parameter in sdata.pl.show(), but figured I'd report anyway.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the extent calculation used by sdata.pl.show(), focusing on how point radius is represented after the calculation moved upstream. Compare the computed extent with the displayed test case and verify that the resulting bounds include point radii.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100