scverse / scverse/spatialdata

Disallow zero-len dataframes when parsing

Open
#662 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

element: labels 🏷️ element: points ⊙ needs: triage priority: low
Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

Parsing dataframes with zero length may lead to subtle bugs and has probably no use case. An example is to to_zarr.py script for the cosmx_io data in the sandbox. Parsing a zero-len dask-dataframe of points lead to a problem with unknown partitions.

We should

  • check for, and disallow, zero-len data in the parser.
  • add tests
  • also add a test to reproduce the bug with the cosmx data.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the parser and the to_zarr.py example for cosmx_io, focusing on how zero-length dask dataframes of points are handled. Add parser tests for rejecting zero-length data and a regression test reproducing the cosmx data bug. Done means the invalid input is disallowed and both test cases pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.