simplify tests where `Identity()` was needed as last transformation in a sequence
Open
Nobody has claimed this yet.
method: transforms 🔃
- Dominant language
- Python
- Stars
- 394
- Forks
- 95
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 7
Description
In a test for sequence transformations I had to add some Identity() transformations due to a limitation of _get_current_output_axes(). See here: https://github.com/scverse/spatialdata/blob/a9fb47776701498a5ecca5e3c5e56a02d59d1224/tests/transformations/test_transformations.py#L435
- verify that this is not needed anymore and drop the
Identity()from the tests
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in tests/transformations/test_transformations.py around line 435 and review why the sequence currently needs trailing Identity() transformations. Verify whether _get_current_output_axes() still has that limitation, then remove the unnecessary Identity() calls and run the transformation tests to confirm they still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100