scverse / scverse/spatialdata

Mixed polygon/multipolygon geometry types from disk

Open
#529 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

element: shapes ▲ I/O 💿
Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

When we read polygons/multipolygons from disk we use the ragged array representation. I have just noticed that the geometry parameter is a single value and not a vector. We need to examine how this behaves when, on disk, we save a mixed collection of polygons and multipolygons. I think I never noticed problems with this in the past, but now that I noticed this we need to verify this case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the disk read/write path for the geometry parameter and its ragged array representation; no file or test is named in the issue. Reproduce a saved mixed collection of polygons and multipolygons, then use the observed behavior to define what a correct read should return and capture that expectation in the project's existing test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.