scverse / scverse/spatialdata

Missing `dtype` validation for labels?

Open
#527 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

element: labels 🏷️
Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

I suspect that we are not enforcing that the dtype for labels should be an integer. We do the check when we validate the target of a table though. We should add this to the schema.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the schema validation for labels and the existing validation for a table target, then compare how their dtypes are checked. The work is done when the labels schema enforces an integer dtype consistently with the table-target validation and the relevant validation checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.