transparent `ShapesModel.parse` geometry arguments
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 394
- Forks
- 95
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 7
Description
The geometry argument is used to select which kind of shapes to create when using ShapesModel.parse.
The possible arguments are 0, 3 and 6 which map to Circles, Polygon and MultiPolygon respectively.
Instead of relying on an incomplete enumeration of GEOS geometry types the argument should accept strings ( "circles", "polygon", "multipolygon").
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ShapesModel.parse entry point and its geometry argument handling. Update the accepted geometry values to the named strings for circles, polygon, and multipolygon, then verify that each selects the corresponding shape type and that the incomplete numeric enumeration is no longer required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100