scverse / scverse/spatialdata

No reloading after saving

Open
#297 0 comments 0 reactions 1 assignee View on GitHub

@giovp is already working on this.

Since Jun 14, 2023.

Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

  • Currently when write() is called, the data is re-read to be made lazy. We have to prevent this because it leads to undesired behavior when one wants to overwrite the data (i.e. data that was in memory should remain in-memory unless the user explicitly wants to load it lazily).
  • In doing this we need to warn the user that the in-memory object may be not performant (especially relevant if calling Interactive() to the output of functions like xenium()). So we should add a check that controls if the data is lazy and backed by a .zarr or .parquet storage (we already have the code for that (see the tests test_io_and_lazy_loading_points() and test_io_and_lazy_loading_raster()), if it is not backed, then when calling Interactive() we should display this warning.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.