scverse / scverse/spatialdata

Spatial query with `target_coordinate_system` not in element

Open
#273 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

Found a bug when querying a SpatialData object or an element that doesn't contain a certain coordinate system and target_coordinate_system is that system.

Fix and test for bounding box query and polygon queries (now fixed only when querying a SpatialData object).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the spatial query implementations for bounding-box and polygon queries, then compare how target_coordinate_system is handled when querying a SpatialData object versus an element. Add regression tests covering a missing coordinate system in both query types. Done means both queries behave correctly and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.