scverse / scverse/spatialdata

Validate transformations when calling `set_transformation`

Open
#266 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

We currently validate transformations when calling transform(), so that transformations that can't be applied raise an error.

After a discussion with @melonora, we should consider adding this validation when the user calls set_transformation(), so that if an invalid transformation is set one would find it immediately.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the set_transformation() and transform() implementations and read how transformations are currently validated during transform(). Move or reuse that validation at set_transformation() so invalid transformations fail immediately while valid ones remain accepted; update or add focused tests for both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.