scverse / scverse/spatialdata

Aggregate: buffering only points, not points and polygons/multipolygons

Open
#251 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

We need to check if we get around the performance issue described in this comment (aggregate.py).

   def circles_to_polygons(df: gpd.GeoDataFrame) -> gpd.GeoDataFrame:
        # We should only be buffering points, not polygons. Unfortunately this is an expensive check.

Related: https://github.com/scverse/spatialdata/issues/214

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in aggregate.py at circles_to_polygons and read related issue 214 for the reported performance problem. Check how points, polygons, and multipolygons are handled, then verify that only points are buffered without regressing aggregation behavior or performance.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.