scverse / scverse/spatialdata

Filtering by coordinate system that doesn't exist returns an empty SpatialData object

Open Beginner friendly
#239 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs: triage priority: low
Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

If a SpatialData object contains the following:
image

If we filter by an incorrect coordinate system name:
sdata = sdata.filter_by_coordinate_system("X")

This returns an empty sdata object.
image

An error message would be good to inform that the coordinate system doesn't exist.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the filter_by_coordinate_system("X") entry point and reproduce the behavior with a coordinate system name that is absent. Trace how the filtered SpatialData object is created and add a regression test for the invalid name. Done means the call reports that the coordinate system does not exist instead of returning an empty object.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.