scverse / scverse/spatialdata

on-disk representation becomes ambigious when shapes contains circles and polygons

Open
#234 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs: triage priority: low
Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

On disk, circles generate the following structure

shapes
|-coords # df with two columns for x/y 
|-Index # index of points
|-radius # radius of points

and polygons the following

shapes
|-coords # df with two columns for x/y 
|-Index # index of polygon
|-offset0 # x-offset specifiying which rows in coords belong to the polygon
|-offset1 # ?

But what happens if we have both in one file?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the on-disk shapes representation described in the issue, comparing the coords, Index, radius, and offset fields for circles and polygons. Determine how a file containing both shape types can identify each record unambiguously; done means the mixed representation has a clear, documented distinction.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.