scverse / scverse/spatialdata

Rename `maintain_positioning` parameter of `BaseTransformation.tranform()`

Open
#148 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
394
Forks
95
Avg merge
4d 3h
Merged PRs (30d)
7

Description

The parameter name is maybe a bit weird. See discussion here to try to find a better name https://github.com/scverse/spatialdata/pull/142#discussion_r1111216166.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the discussion linked from the issue, then locate BaseTransformation.tranform() and its maintain_positioning parameter and references. The naming decision is not recorded in the issue itself; done means applying the agreed rename consistently without changing behavior and checking the affected references.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.