scverse / scverse/spatialdata-io
z_index = 0 for polygons in MERSCOPE
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 103
- Forks
- 65
- Avg merge
- 1h 8m
- Merged PRs (30d)
- 3
Description
This commit seems to solve my issue reported here: https://github.com/scverse/spatialdata-io/issues/208
Is there a reason why only polygons from z_index = 0 are kept? By default the reader select plane z=3.
Originally posted by @MathieuBo in https://github.com/scverse/spatialdata-io/issues/207#issuecomment-2358626502
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the linked issues 207 and 208 and the referenced commit first to establish the intended MERSCOPE behavior. Then locate the MERSCOPE reader's polygon and z-plane handling; done means the selected plane's polygons are handled consistently rather than silently keeping only z_index=0, with the relevant behavior covered by tests if existing coverage is available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100