scverse / scverse/scanpy

Broken Scrublet Test

Open
#3,068 0 comments 0 reactions 1 assignee View on GitHub

@ilan-gold is already working on this.

Since May 17, 2024.

Dominant language
Python
Stars
2.6k
Forks
779
Avg merge
1d 4h
Merged PRs (30d)
27

Description

Please make sure these conditions are met
  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of scanpy.
  • (optional) I have confirmed this bug exists on the main branch of scanpy.
What happened?

Both https://github.com/scverse/scanpy/commit/23c20bc4dd3b1a1e5432ad4e23f56cf5efcf7ebe and https://dev.azure.com/scverse/scanpy/_build/results?buildId=6733&view=logs&j=cb4d9293-b492-5d67-02b0-e6a595893958&t=99aeec2e-a40e-57fc-1ab3-27c1a626c3e0&s=96ac2280-8cb4-5df5-99de-dd2da759617d show errors from scrublet which I cannot reproduce locally

Minimal code sample
See `test_scrublet_data` under `anndata_dev`
Error output
E           AssertionError: 
E           Not equal to tolerance rtol=1e-15, atol=1e-15
E           
E           Mismatched elements: 1 / 200 (0.5%)
E           Max absolute difference: 0.0126501664
E           Max relative difference: 0.1823112224
E            x: array([0.033079, 0.039326, 0.047022, 0.069388, 0.047022, 0.033079,
E                  0.069388, 0.019841, 0.069388, 0.069388, 0.069388, 0.039326,
E                  0.033079, 0.149254, 0.047022, 0.056738, 0.047022, 0.023555,...
E            y: array([0.033079, 0.039326, 0.047022, 0.069388, 0.047022, 0.033079,
E                  0.069388, 0.019841, 0.069388, 0.069388, 0.069388, 0.039326,
E                  0.033079, 0.149254, 0.047022, 0.056738, 0.047022, 0.023555,...
Versions
Package           Version
----------------- -------------------------
anndata           0.11.0.dev114+g105f354
annoy             1.17.3
scipy             1.13.0
scprep            1.1.0
seaborn           0.13.2
session-info      1.0.0
setuptools        69.5.1
setuptools-scm    8.1.0
six               1.16.0
sniffio           1.3.1
sortedcontainers  2.4.0
sparse            0.16.0a6
statsmodels       0.14.2
stdlib-list       0.10.0
tasklogger        1.2.0
tblib             3.0.0
texttable         1.7.0
textual           0.60.1
threadpoolctl     3.5.0
tifffile          2024.5.10
toolz             0.12.1
tornado           6.4
tqdm              4.66.4
typing-extensions 4.12.0rc1
tzdata            2024.1
uc-micro-py       1.0.3
umap-learn        0.5.6
urllib3           2.2.1
uv                0.1.44
virtualenv        20.26.2
wrapt             1.16.0
zarr              2.18.1
zict              3.0.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.