scverse / scverse/scanpy

`pl.rank_genes_groups_violin` should be able to pass `**kwds` to `pl.violin`

Open Beginner friendly
#2,954 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.6k
Forks
779
Avg merge
1d 4h
Merged PRs (30d)
27

Description

What kind of feature would you like to request?

Additional function parameters

Please describe your wishes

All the plotting functions in the pl.rank_genes_groups_<plot-type> group are able to pass additional keywords to their parent plot type for extra tuning, apart from pl.rank_genes_groups_violin. Was this by design, or is it an omission? If the latter, I'm happy to work on a PR to fix it (I found myself today wanting to pass log=True, only to get an error).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the implementations of pl.rank_genes_groups_violin and pl.violin, then compare how the other pl.rank_genes_groups_ functions forward additional keywords. Confirm that the violin variant accepts and forwards plot-tuning keywords such as log=True, and verify the relevant plotting behavior with the existing test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.