scverse / scverse/scanpy

`test_plotting.py` imports scrublet, shall be moved?

Open
#2,158 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area – External
Dominant language
Python
Stars
2.6k
Forks
779
Avg merge
1d 4h
Merged PRs (30d)
27

Description

https://github.com/theislab/scanpy/blob/0fde3f6cf93806bb1be1ac5fa4449da8a670fcf3/scanpy/tests/test_plotting.py#L1504

should it be moved in tests externals? if not, then flit install -s --deps=develop doesn't install scrublet whereas it should imho otherwise test fails for fail import

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at scanpy/tests/test_plotting.py around line 1504 and inspect how the test imports scrublet. Run flit install -s --deps=develop and the affected plotting test to reproduce the missing-import failure. Done means the development setup installs the needed dependency, or the test is moved to the external tests if that is the intended scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.